Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve baseline alignment for right-side text blocks #643

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

rebeccacremona
Copy link
Contributor

We have been struggling to align right-side text blocks with left-side headings. In that PR description, Chris mentions that align-items: baseline or the associated Tailwind class seems like the way to go, but reported having trouble getting it working.

For whatever reason, I seem to have had success!

The visual difference is subtle, but is indeed an improvement.

Copy link
Contributor

@cmsetzer cmsetzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have no idea what I was doing wrong, but glad you double-checked. So much nicer than adjusting the padding.

@rebeccacremona rebeccacremona merged commit 3852c58 into harvard-lil:redesign Dec 5, 2024
1 check passed
@rebeccacremona rebeccacremona deleted the align-baseline branch December 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants