Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent animation rate across expandable elements #644

Merged

Conversation

cmsetzer
Copy link
Contributor

@cmsetzer cmsetzer commented Dec 5, 2024

Before:

  • animationSpeed was an attribute of LilHeader
  • animationSpeed affected not only the LilHeader nav menu, but also Swup transitions and the +/- icon that displays when opening LilExpandable on the Careers page
  • However, animationSpeed did not affect the actual expandable content in LilExpandable, opening up the potential for harmless but weird effects if the user clicked an expandable multiple times in quick succession

After:

  • animationSpeed has been renamed to the more descriptive animationRate
  • animationRate is now a global constant, not a property of LilHeader
  • animationRate now affects all elements of LilExpandable consistently, preventing the aforementioned visual bugs
  • Tweaked LilExpandable transition durations a bit to fit better with other elements

@cmsetzer cmsetzer requested a review from bensteinberg December 5, 2024 22:58
@bensteinberg
Copy link
Contributor

(I'm going to take the liberty of merging this.)

@bensteinberg bensteinberg merged commit e5c3dfd into harvard-lil:redesign Dec 6, 2024
1 check passed
@cmsetzer cmsetzer deleted the tweak-expandable-animation-rate branch December 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants