Ensure consistent animation rate across expandable elements #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
animationSpeed
was an attribute ofLilHeader
animationSpeed
affected not only theLilHeader
nav menu, but also Swup transitions and the+/-
icon that displays when openingLilExpandable
on the Careers pageanimationSpeed
did not affect the actual expandable content inLilExpandable
, opening up the potential for harmless but weird effects if the user clicked an expandable multiple times in quick successionAfter:
animationSpeed
has been renamed to the more descriptiveanimationRate
animationRate
is now a global constant, not a property ofLilHeader
animationRate
now affects all elements ofLilExpandable
consistently, preventing the aforementioned visual bugsLilExpandable
transition durations a bit to fit better with other elements