Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS cache-buster #650

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

bensteinberg
Copy link
Contributor

This is a first cut at a JS cache-buster, along the lines of our existing CSS cache-busting mechanism. It renames the CSS cache-buster to distinguish it from this one. It also corrects the branch name, which I failed to update in #647.

I think it's not necessary to handle files in build/assets/lib/, as they're versioned. TBD: should we handle the JS in the century-scale storage article? build/postcss.config.js and build/tailwind.config.js?

Copy link
Contributor

@rebeccacremona rebeccacremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘 Thanks for doing this!

I think it's not necessary to handle files in build/assets/lib/, as they're versioned.

Agreed.

TBD: should we handle the JS in the century-scale storage article?

Nah. I feel like, if we make significant changes there, which seems unlikely, and we are worried about it, we could just deal with it manually.

build/postcss.config.js and build/tailwind.config.js?

Ah, good one!! I think if those change, then the CSS cache needs to be busted.

@bensteinberg
Copy link
Contributor Author

Thanks -- I'll make a change for the Tailwind stuff.

@bensteinberg
Copy link
Contributor Author

build/*.config.js might not be correct if we added some other JS config file at the top level, but we can cross that bridge when we get to it.

@bensteinberg bensteinberg merged commit 105c41b into harvard-lil:develop Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants