Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: api basic tests #972

Closed
wants to merge 1 commit into from
Closed

test: api basic tests #972

wants to merge 1 commit into from

Conversation

YaelChen
Copy link
Collaborator

Description

I'm trying to learn about API and requests, don't know if these tests are needed and whether they're in the correct place...
These are my attempts for a very simple sanity test and load (or even basic stress) test.

@YaelChen YaelChen requested a review from NoamGaash December 11, 2024 11:28
@NoamGaash
Copy link
Member

Hi Yael! Following our discussion, planning and maintaining API test suit could be a great addition to the project. However, the endpoints tested in this specific pull request are already tested more rigorously in our e2e test suit.
An api test contribution could be nice if it will test either the data availability (for example nightly run to see if there were at least 100 rides in the past day, and make a slack notification when it's failing) or in the context of testing the API logic which is more complicated and would be helpful in the API repository.
What do you think?

@YaelChen
Copy link
Collaborator Author

Sure, it was just my first attempt at playing around with these kinds of tests, but I still lack some knowledge of the subject.
I'll close this pr as it's not relevant, and hopefully address these subjects in the future :)

@YaelChen YaelChen closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants