allocrunner: automatically stop batch types allocations. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when running batch type jobs (batch/sysbatch), the allocs would run until the user initiated shutdown. This is not how batch workloads run and caused load testing problems as nodes would fill with running workload. This problem can be overcome by using the "real" allocrunner, but adds resource overhead on the nodesim process. Automatically stopping batch workload mimics real work and allows us to use the simulated allocrunner for a lighter overhead. This means benchmarking can be cheaper and easier to run.
schmichael
approved these changes
Apr 17, 2024
| @@ -174,6 +174,24 @@ func (ar *simulatedAllocRunner) Run() { | |||
| ar.allocStateLock.Unlock() | |||
|
|
|||
| ar.updateAllocAndSendUpdate(taskStates) | |||
|
|
|||
| // Who wants to live forever? | |||
There was a problem hiding this comment.
There's no time for us
-- batch jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when running batch type jobs (batch/sysbatch), the allocs would run until the user initiated shutdown. This is not how batch workloads run and caused load testing problems as nodes would fill with running workload. This problem can be overcome by using the "real" allocrunner, but adds resource overhead on the nodesim process.
Automatically stopping batch workload mimics real work and allows us to use the simulated allocrunner for a lighter overhead. This means benchmarking can be cheaper and easier to run.