VAULT-31184: Support identity token auth in data_artifactory_item
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to read this pull request
The primary motivation for this PR is to add support for identity token auth to the
artifactory_item
datasource. This will allow us to migrate from API auth to identity token auth. We maintain backwards compatibility with API auth and do not change any schema, except forusername
no longer being required. If no username is provided we assume token that is required is for identity token auth, not API auth.Note
Since this is a repo in the forge and public we cannot utilize the doormat action to test token auth in CI. As such, I've tested both the artifactory package and the datasource ACC tests locally using both identity token and API auth.
We also do a bit of housekeeping and update our Go modules and pin to the latest Github actions.
Note
We are currently behind on
terraform-plugin-go
as the server interface now requires implementing provider functions, which we have not done yet.Checklist