Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 default to light theme for acceptance tests #2587

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

cameronperera
Copy link
Collaborator

Description

This is a temporary fix our a11yAudits failing due to the dark color theme. I have work to address that but until that work is started, this will set the default theme to the light color theme. This shouldn't be too much of a change outside of the test that specifically test the theme toggle.

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Nov 21, 2024
@cameronperera cameronperera requested a review from a team as a code owner November 21, 2024 22:11
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 5:11pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 5:11pm

Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!! left a comment for learning more 😉

calcaide
calcaide previously approved these changes Nov 26, 2024
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! left a none blocking comment

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@cameronperera cameronperera merged commit b24e5a2 into main Dec 2, 2024
12 checks passed
@cameronperera cameronperera deleted the fix/a11y-audit-default-to-light-theme branch December 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants