test: add grants test for auth-token resource #5588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elimt
force-pushed
the
elimt-auth-tokens-grants-test
branch
from
89e5134 to
aae3126
Compare
bosorawis
reviewed
Mar 13, 2025
| } | ||
| } | ||
|
|
||
| func TestGrants_Read(t *testing.T) { |
There was a problem hiding this comment.
Could you add a test that covers output_fields=* to verify that all the fields are being returned properly in the happy path case?
bosorawis
reviewed
Mar 13, 2025
| if tc.wantErr != nil { | ||
| require.ErrorIs(t, finalErr, tc.wantErr) | ||
| return | ||
| testcases := []struct { |
There was a problem hiding this comment.
Could you add a few negative tests for missing permissions, tests with specific scope grants, and tests with specific resource ID grants?
bosorawis
reviewed
Mar 13, 2025
| } | ||
| } | ||
|
|
||
| func TestGrants_ReadSelf(t *testing.T) { |
There was a problem hiding this comment.
can you add a case that covers grants with specific resource ID?
bosorawis
reviewed
Mar 13, 2025
| } | ||
| } | ||
|
|
||
| func TestGrants_DeleteSelf(t *testing.T) { |
There was a problem hiding this comment.
tests for specific resource ID grants
bosorawis
approved these changes
Mar 13, 2025
* Fix bug where the `ParentScopeId` is not set when fetching output fields for a resource. Output fields were not being respected for children grant scopes.
- add test that tests the grants for the auth-token resource with different actions, scopes and output fields
elimt
force-pushed
the
elimt-auth-tokens-grants-test
branch
from
85c9230 to
0fcf4e5
Compare
Base automatically changed from
bosorawis-prototype-grant-test
to
llb-normalized-grants-tests-only
March 26, 2025 21:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add grants test for auth-token resource
ParentScopeIdis not set when fetching output fields for a resource. Output fields were not being respected for children grant scopes.