Test: GrantsForUser for Accounts for various user to role relationships #5631
+992
−1,590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkanney
force-pushed
the
dkanney-test-grants-for-user-accounts
branch
2 times, most recently
from
a1f09df to
d173538
Compare
This could be useful across the app as a generic array Map function, so I'm moving it to a helper package.
Note: These tests will fail until GrantsForUser is refactored to return only grants whose scopes are applicable to this resource
dkanney
force-pushed
the
dkanney-test-grants-for-user-accounts
branch
from
d173538 to
3504df7
Compare
tmessi
requested changes
Apr 28, 2025
|
|
||
| // Map maps a slice of one type into a slice of another using the provided map | ||
| // function | ||
| func Map[T, U any](in []T, f func(T) U) []U { |
There was a problem hiding this comment.
Is there a need to move this into a separate package? Are we planning on using this elsewhere? If not I would rather leave this in the test package. If we do expect to use this in other places, lets put this in a more descriptive package name and avoid using util.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the existing GrantsForUser tests from #5443. The logic between these tests is mostly the same -- the only variables are:
As a result, it made sense to refactor the existing three tests into one. Now passing in a principal (the thing being associated to roles), and a role association function (tells us how to associate the principal to its roles)
Note: The tests for
resource.Accountwill not pass until the GrantsForUser refactor is complete. In its current state,GrantsForUser()returns all grants for a user. After the refactor, it'll return a subset of grants based on some new parameters (i.e. resource type, request scope, recursive option). Until then, tests forresource.Accountwill return roles for all scopes even thoughresource.Accountcan only exist at the Global and Org scopes.