Skip to content

Commit

Permalink
Fix test and add CI (#321)
Browse files Browse the repository at this point in the history
  • Loading branch information
schmichael authored Oct 21, 2024
1 parent 0c4f564 commit 7e5ceaa
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
41 changes: 41 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: CI Tests
on:
pull_request:
paths-ignore:
- 'README.md'
push:
branches:
- 'main'
paths-ignore:
- 'README.md'

permissions:
contents: read

jobs:
go-fmt-and-vet:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
- uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0
with:
go-version: '1.20'
cache: true
- run: |
files=$(go fmt ./...)
if [ -n "$files" ]; then
echo "The following file(s) do not conform to go fmt:"
echo "$files"
exit 1
fi
go-test:
needs: go-fmt-and-vet
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
- uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568 # v3.5.0
with:
go-version: '1.20'
cache: true
- run: |
go test -race ./...
2 changes: 1 addition & 1 deletion grpc_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func testGRPCClientReflection(t *testing.T, multiplex bool) {
}

// TODO: maybe only assert some specific services here to make test more resilient
expectedSvcs := []string{"grpc.health.v1.Health", "grpc.reflection.v1alpha.ServerReflection", "grpctest.Test", "plugin.GRPCBroker", "plugin.GRPCController", "plugin.GRPCStdio"}
expectedSvcs := []string{"grpc.health.v1.Health", "grpc.reflection.v1.ServerReflection", "grpc.reflection.v1alpha.ServerReflection", "grpctest.Test", "plugin.GRPCBroker", "plugin.GRPCController", "plugin.GRPCStdio"}

if !reflect.DeepEqual(svcs, expectedSvcs) {
t.Fatalf("expected: %v\ngot: %v", expectedSvcs, svcs)
Expand Down

0 comments on commit 7e5ceaa

Please sign in to comment.