Skip to content

Commit

Permalink
remove preciousness
Browse files Browse the repository at this point in the history
I was using an initial comparison to `true` so that all of the other
comparisons ended up in a straight line down, but it's not idiomatic.
  • Loading branch information
angrycub committed Sep 5, 2023
1 parent 6d3b959 commit 3cc48e8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sdk/pack/variables/variables.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ func (v *Variable) SetType(t cty.Type) { v.Type = t; v.hasType = true }
func (v Variable) String() string { return asJSON(v) }

func (v Variable) Equal(ov Variable) bool {
eq := true &&
v.Name == ov.Name &&
eq := v.Name == ov.Name &&
v.Description == ov.Description &&
v.hasDescription == ov.hasDescription &&
v.Default == ov.Default &&
Expand Down

0 comments on commit 3cc48e8

Please sign in to comment.