Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of deps: update go-plugin to 1.6.2 into release/1.9.x #24267

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #24265 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.


During allocation recovery, the go-plugin reattachment workflow checks to see if the PID we stored in client state is still running. If so, we try to connect to that process. If that fails, we kill the process under the presumption it's not working. But during reattachment we don't know that the PID we have is still valid. Which means that the process we're trying to attach to may have exited and a different process has spawned with the same PID. This results in some unrelated process getting silently killed.

Update go-plugin to 1.6.2, which includes a bug fix so we do not kill the process.

Fixes: #23969
Ref: https://hashicorp.atlassian.net/browse/NET-11233


Overview of commits

@tgross tgross merged commit 5172358 into release/1.9.x Oct 21, 2024
19 of 20 checks passed
@tgross tgross deleted the backport/go-plugin-1.6.2/strictly-cute-dog branch October 21, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants