Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some details of the terraform readme file for e2e provisioning #24451

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

Juanadelacuesta
Copy link
Member

Description

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this Juanita. I left some suggestions.

e2e/terraform/README.md Outdated Show resolved Hide resolved
e2e/terraform/README.md Outdated Show resolved Hide resolved
e2e/terraform/terraform.tfvars Outdated Show resolved Hide resolved
Juanadelacuesta and others added 3 commits November 18, 2024 13:36
Co-authored-by: Piotr Kazmierczak <[email protected]>
Co-authored-by: Piotr Kazmierczak <[email protected]>
@Juanadelacuesta Juanadelacuesta merged commit 270b4f9 into main Nov 18, 2024
7 of 9 checks passed
@Juanadelacuesta Juanadelacuesta deleted the NOJIRA-e2e-readme branch November 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants