Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui, ci] Ember Exam failures should cause overall test failures #24603

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions .github/workflows/test-ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ on:
- test-ui
paths:
- "ui/**"
- "scripts/combine-ui-test-results.js"
- ".github/workflows/test-ui.yml"

jobs:
pre-test:
Expand All @@ -36,6 +38,7 @@ jobs:
- pre-test
runs-on: ${{ endsWith(github.repository, '-enterprise') && fromJSON('["self-hosted", "ondemand", "linux", "type=m7a.2xlarge;m6a.2xlarge"]') || 'ubuntu-latest' }}
timeout-minutes: 30
continue-on-error: true
defaults:
run:
working-directory: ui
Expand All @@ -61,15 +64,23 @@ jobs:
secrets: |-
kv/data/teams/nomad/ui PERCY_TOKEN ;
- name: ember exam
id: exam
env:
PERCY_TOKEN: ${{ env.PERCY_TOKEN || secrets.PERCY_TOKEN }}
PERCY_PARALLEL_NONCE: ${{ needs.pre-test.outputs.nonce }}
run: |
yarn exam:parallel --split=${{ matrix.split }} --partition=${{ matrix.partition }} --json-report=test-results/test-results.json
continue-on-error: true
- name: Express timeout failure
if: ${{ failure() }}
run: exit 1
# # We have continue-on-error set to true, but we still want to alert the author if
# # there are test failures or timeouts. Without it, we'll get errors in our output,
# # but the workflow will still succeed / have a green checkmark.
# - name: Express timeout failure
# if: ${{ failure() }}
# run: exit 1
# - name: Check test status
# if: steps.exam.outcome != 'success'
# run: |
# echo "Tests failed or timed out in partition ${{ matrix.partition }}"
# exit 1
- name: Upload partition test results
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
Expand Down
3 changes: 2 additions & 1 deletion ui/tests/acceptance/clients-list-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ module('Acceptance | clients list', function (hooks) {

await percySnapshot(assert);

assert.equal(ClientsList.nodes.length, ClientsList.pageSize);
// assert.equal(ClientsList.nodes.length, ClientsList.pageSize);
assert.equal(ClientsList.nodes.length, 31); // deliberate failure
assert.ok(ClientsList.hasPagination, 'Pagination found on the page');

const sortedNodes = server.db.nodes.sortBy('modifyIndex').reverse();
Expand Down
Loading