Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let nomad education and web presence merge PRs to website files #24621

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

judithpatudith
Copy link
Contributor

@judithpatudith judithpatudith commented Dec 6, 2024

Description

Let nomad education and web presence merge PRs to website files

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@judithpatudith judithpatudith marked this pull request as ready for review December 6, 2024 22:47
@judithpatudith judithpatudith requested review from a team as code owners December 6, 2024 22:47
@judithpatudith judithpatudith changed the title Let nomad education and web presence merge PRs website files Let nomad education and web presence merge PRs to website files Dec 6, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross merged commit 76fcc6f into main Dec 9, 2024
26 checks passed
@tgross tgross deleted the judith/edu-web-codeowners branch December 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants