Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Cross region endpoint service support #40346

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Nov 28, 2024

Description

Adds cross region support to aws_vpc_endpoint_service.
This doesn't add this to the datasource as the ServiceDetail used by that data source does not returned SupportedRegions as ServiceConfiguration does so requires a bit more work.

Relations

Closes #40321.

References

Output from Acceptance Testing

% make testacc P=5 TESTS=TestAccVPCEndpointService_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccVPCEndpointService_'  -timeout 360m
2024/11/28 12:08:32 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN   TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN   TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN   TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN   TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN   TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN   TestAccVPCEndpointService_crossRegion
=== PAUSE TestAccVPCEndpointService_crossRegion
=== CONT  TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpointService_allowedPrincipals
=== CONT  TestAccVPCEndpointService_privateDNSName
=== CONT  TestAccVPCEndpointService_crossRegion
=== CONT  TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_basic (246.69s)
=== CONT  TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_privateDNSName (250.78s)
=== CONT  TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_crossRegion (257.35s)
=== CONT  TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_allowedPrincipals (274.69s)
=== CONT  TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (357.43s)
--- PASS: TestAccVPCEndpointService_tags (252.35s)
--- PASS: TestAccVPCEndpointService_disappears (240.90s)
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (289.88s)
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (425.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        676.852s

@drewtul drewtul requested a review from a team as a code owner November 28, 2024 12:00
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 28, 2024
@drewtul drewtul changed the title Initial implemenation of cross region endpoint service [Enhancement] Cross region endpoint service support Nov 28, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2024
@ewbankkit ewbankkit self-assigned this Dec 2, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 2, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_THIRD_REGION=eu-west-1 make testacc TESTARGS='-run=TestAccVPCEndpointService_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCEndpointService_ -timeout 360m
2024/12/02 12:16:33 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN   TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN   TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN   TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN   TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN   TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN   TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN   TestAccVPCEndpointService_crossRegion
=== PAUSE TestAccVPCEndpointService_crossRegion
=== CONT  TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpointService_allowedPrincipals
=== CONT  TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_basic (233.49s)
=== CONT  TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_allowedPrincipals (259.14s)
=== CONT  TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (414.54s)
=== CONT  TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (251.03s)
=== CONT  TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointService_tags (257.83s)
=== CONT  TestAccVPCEndpointService_crossRegion
--- PASS: TestAccVPCEndpointService_disappears (220.39s)
=== CONT  TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_privateDNSName (250.44s)
--- PASS: TestAccVPCEndpointService_crossRegion (307.69s)
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (356.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	996.607s

@github-actions github-actions bot added the service/opsworks Issues and PRs that pertain to the opsworks service. label Dec 2, 2024
@ewbankkit ewbankkit merged commit dd70d80 into hashicorp:main Dec 2, 2024
48 checks passed
@github-actions github-actions bot added this to the v5.79.0 milestone Dec 2, 2024
@drewtul drewtul deleted the f-privatelink-cross-region branch December 2, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/opsworks Issues and PRs that pertain to the opsworks service. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support PrivateLink Cross Region Connectivity
3 participants