-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Cross region endpoint service support #40346
Merged
Merged
+143
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/vpc
Issues and PRs that pertain to the vpc service.
needs-triage
Waiting for first response or review from a maintainer.
partner
Contribution from a partner.
labels
Nov 28, 2024
drewtul
changed the title
Initial implemenation of cross region endpoint service
[Enhancement] Cross region endpoint service support
Nov 28, 2024
ewbankkit
removed
the
needs-triage
Waiting for first response or review from a maintainer.
label
Dec 2, 2024
github-actions
bot
added
the
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
label
Dec 2, 2024
ewbankkit
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_THIRD_REGION=eu-west-1 make testacc TESTARGS='-run=TestAccVPCEndpointService_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCEndpointService_ -timeout 360m
2024/12/02 12:16:33 Initializing Terraform AWS Provider...
=== RUN TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN TestAccVPCEndpointService_crossRegion
=== PAUSE TestAccVPCEndpointService_crossRegion
=== CONT TestAccVPCEndpointService_basic
=== CONT TestAccVPCEndpointService_allowedPrincipals
=== CONT TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_basic (233.49s)
=== CONT TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_allowedPrincipals (259.14s)
=== CONT TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (414.54s)
=== CONT TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (251.03s)
=== CONT TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointService_tags (257.83s)
=== CONT TestAccVPCEndpointService_crossRegion
--- PASS: TestAccVPCEndpointService_disappears (220.39s)
=== CONT TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_privateDNSName (250.44s)
--- PASS: TestAccVPCEndpointService_crossRegion (307.69s)
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (356.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 996.607s
github-actions
bot
added
the
service/opsworks
Issues and PRs that pertain to the opsworks service.
label
Dec 2, 2024
YakDriver
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
partner
Contribution from a partner.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/opsworks
Issues and PRs that pertain to the opsworks service.
service/vpc
Issues and PRs that pertain to the vpc service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds cross region support to
aws_vpc_endpoint_service
.This doesn't add this to the datasource as the
ServiceDetail
used by that data source does not returnedSupportedRegions
asServiceConfiguration
does so requires a bit more work.Relations
Closes #40321.
References
Output from Acceptance Testing