Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add excludeResourceTags for aws_rbin_rule #40937

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

hacker65536
Copy link
Contributor

@hacker65536 hacker65536 commented Jan 15, 2025

Description

add excludeResourceTags for aws_rbin_rule

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@hacker65536 hacker65536 requested a review from a team as a code owner January 15, 2025 10:47
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the service/rbin Issues and PRs that pertain to the rbin service. label Jan 15, 2025
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 15, 2025
@hacker65536 hacker65536 force-pushed the rbin_exclude_tags branch 2 times, most recently from f5770a6 to c5bff2d Compare January 15, 2025 16:38
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 15, 2025
@hacker65536 hacker65536 changed the title feat: add excludeResourceTags for aws_rbin_rule (WIP) feat: add excludeResourceTags for aws_rbin_rule Feb 25, 2025
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rbin Issues and PRs that pertain to the rbin service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants