-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor issue-comment-created.yml to avoid actions-ecosystem/action-remove-labels
#14774
Conversation
** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you! |
Closing because I overlooked that internal forks won't work with a public repo 😢 |
** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you! |
However GitHub will not run node12 actions tomorrow, so a temporary measure is needed. Either this PR or disabling of the action/communication to triage and BOD roles that the label won't automatically be removed. Edit: in the end I just made a new action |
actions-ecosystem/action-remove-labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll merge this, but we're working to get a HasiCorp fork of the original action. Once that's happened and we push the upgrade from Node12 => Node16 we will resume using |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Closes #14623
This PR replaces the contents of
issue-comment-created.yml
to avoid usingactions-ecosystem/action-remove-labels
.actions-ecosystem/action-remove-labels
appears to be unmaintained and only works on Node 12.GitHub is planning to stop using Node 12 soon: https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/