Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor issue-comment-created.yml to avoid actions-ecosystem/action-remove-labels #14774

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented May 31, 2023

Closes #14623

This PR replaces the contents of issue-comment-created.yml to avoid using actions-ecosystem/action-remove-labels.

actions-ecosystem/action-remove-labels appears to be unmaintained and only works on Node 12.

GitHub is planning to stop using Node 12 soon: https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/

Following on from our warning in workflows using Node 12, we will start enforcing the use of Node16 rather than Node12 on the 14th of June.

@github-actions
Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from ScottSuarez May 31, 2023 18:15
@SarahFrench SarahFrench removed the request for review from ScottSuarez May 31, 2023 18:20
@SarahFrench
Copy link
Member Author

Closing because I overlooked that internal forks won't work with a public repo 😢

@SarahFrench SarahFrench reopened this May 31, 2023
@github-actions
Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from megan07 May 31, 2023 18:45
@SarahFrench
Copy link
Member Author

SarahFrench commented May 31, 2023

We don't have the ability to create a public fork quickly, so here's a public fork under my account as a temporary solution.

In the longer term we either need to find a replacement GHA or make a new one - I think using the action/github-script action like in this page of the docs is what would be used.

However GitHub will not run node12 actions tomorrow, so a temporary measure is needed. Either this PR or disabling of the action/communication to triage and BOD roles that the label won't automatically be removed.

Edit: in the end I just made a new action

@SarahFrench SarahFrench requested a review from ScottSuarez May 31, 2023 18:46
@github-actions github-actions bot added size/s and removed size/xs labels May 31, 2023
@SarahFrench SarahFrench changed the title Update dependencies in issue-comment-created.yml Refactor issue-comment-created.yml to avoid actions-ecosystem/action-remove-labels May 31, 2023
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SarahFrench
Copy link
Member Author

I'll merge this, but we're working to get a HasiCorp fork of the original action. Once that's happened and we push the upgrade from Node12 => Node16 we will resume using action-remove-labels but it'll be hashicorp/action-remove-labels instead of actions-ecosystem/action-remove-labels.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
@SarahFrench SarahFrench deleted the update-issue-comment-created-action branch August 7, 2023 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions - deprecated warnings found - action required!
2 participants