Fixed HttpCodec Check #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mercedesbh
reviewed
Mar 8, 2024
…orm-provider-hcp into hotfix/http-codec-check
|
@jaireddjawed Any updates on when this will be released? |
Reached out to team-cloud-foundations again for a review just now. Hopefully, they'll take a final look at this and get it approved soon. |
manish-hashicorp
approved these changes
Apr 3, 2024
catsby
added a commit
that referenced
this pull request
Apr 5, 2024
* main: updated documentation updated CHANGELOG.md Add DataDog config to HCP Log Streaming Destination (#803) Add in-place update to HCP Log Streaming Destination (#802) Update error messages in HCP provider config Refactor code to require specific organization configuration changelog Handle multiple organizations for credentials Fixed HttpCodec Check (#781) updated documentation updated CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR fixes an issue where the
httpMethodis checked to see if its value is equal toJSONorNDJSON(in addition to its actual). This was a typo,httpCodecwas supposed to be checked to see if it was equal to those values.🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...