Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description for set_list parameters #1451

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

rhowe
Copy link
Contributor

@rhowe rhowe commented Aug 7, 2024

Description

This looks like copypasta from set_sensitive.

Acceptance tests

  • [N/A] Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Fix descriptions for `set_list` parameters

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

This looks like copypasta from `set_sensitive`.
@rhowe rhowe requested a review from a team as a code owner August 7, 2024 10:51
Copy link

hashicorp-cla-app bot commented Aug 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@BBBmau BBBmau added pr/no-changelog no-documentation This issue or pull request does not have documentation changes. labels Aug 7, 2024
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing Documentation workflow can be ignored since it's being worked on right now.

Thank you for catching this!

@BBBmau BBBmau merged commit 031e5c7 into hashicorp:main Aug 7, 2024
22 of 25 checks passed
@rhowe rhowe deleted the fix-helm-release-set-list-docs branch August 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-documentation This issue or pull request does not have documentation changes. pr/no-changelog size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants