Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exec block from List to SingleNestedAttribute in KubernetesConfigModel #1496

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Refactor exec block from List to SingleNestedAttribute in KubernetesConfigModel #1496

merged 8 commits into from
Jan 7, 2025

Conversation

JaylonmcShan03
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 commented Oct 4, 2024 •
edited
Loading

Description

This PR refactors the exec and kubernetes block in the KubernetesConfigModel from a ListNestedAttribute to a SingleNestedAttribute. The exec block was previously defined as a list, allowing multiple configurations, but the actual use case only requires one configuration.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner October 4, 2024 13:23
@JaylonmcShan03 JaylonmcShan03 force-pushed the refactor-exec-to-single-nested-attribute branch from 5171a0c to 092c8c9 Compare October 15, 2024 14:50
@JaylonmcShan03 JaylonmcShan03 force-pushed the refactor-exec-to-single-nested-attribute branch from 092c8c9 to 2a1e935 Compare December 18, 2024 17:39
@github-actions github-actions bot added size/XL and removed size/L labels Dec 20, 2024
@jrhouston jrhouston merged commit 31737da into helm-framework Jan 7, 2025
4 of 9 checks passed
@jrhouston jrhouston deleted the refactor-exec-to-single-nested-attribute branch January 7, 2025 18:34
jrhouston pushed a commit that referenced this pull request Jan 7, 2025
@JaylonmcShan03 @jrhouston
Refactor exec block from List to SingleNestedAttribute in KubernetesC…
4d9c7cf 
…onfigModel (#1496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin-framework size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaylonmcShan03 @jrhouston