Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer deref panic on helm_release destroy #1501

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix nil pointer deref panic on helm_release destroy #1501

merged 1 commit into from
Oct 15, 2024

Conversation

sbocinec
Copy link
Contributor

@sbocinec sbocinec commented Oct 11, 2024 •
edited
Loading

Description

Fix nil pointer deref panic in helm_resource introduced in 2.16.0 through GH-1487. This occurs, when the to-be-destroyed resource no more exists in K8s and helm returns "release not found" as the response is nil in this case.

Fixes #1500

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Fix helm_resource destroy panic when helm chart release is not found

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sbocinec sbocinec requested a review from a team as a code owner October 11, 2024 15:23
@sbocinec sbocinec force-pushed the fix-nil-ptr-deref-destroy branch from 2b9f6ed to aa8da65 Compare October 11, 2024 15:32
@sbocinec sbocinec changed the title Fix nil pointer deref panic in helm resource destroy Fix nil pointer deref panic on helm_release destroy Oct 11, 2024
@sbocinec
Fix nil pointer deref panic on helm_release destroy
e53e1b0 
The destroy panics when helm returns "release not found" as the returned
response is nil.
@sbocinec sbocinec force-pushed the fix-nil-ptr-deref-destroy branch from aa8da65 to e53e1b0 Compare October 11, 2024 15:34
@sbocinec sbocinec mentioned this pull request Oct 11, 2024
Closed
@BBBmau BBBmau merged commit 48730a7 into hashicorp:main Oct 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheneska sheneska sheneska approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm provider 2.16.0 panics when destroy returns "release not found"
3 participants
@sbocinec @sheneska @BBBmau