-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supress empty description test #1521
Open
JaylonmcShan03
wants to merge
52
commits into
main
Choose a base branch
from
supress-empty-description-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata models. This is the current working version of the data source
* rename: helmReleaseModel -> HelmReleaseModel * tidying up during code review
* Fix acronyms in struct field names in kubeConfig.go and provider.go * Fixed acronym in kubeConfig that wasnt pushed in previous pr * Refactored debug handling to use a boolean variable * removing unnessary comment * Updating the debug two conditionals into one * Fixing edge case logic * Simpliyfing if statements * Fixing location of debug variable
…h list of objects structure (#1470)
* remove duplicate logs * refactor to use recomputeMetadata method * use Equal for version check in useChartVersion * more cleanup in useChartVersion / removing quotation removal from version * refactor valuesKnown method in ModifyPlan * remove null check in valuesKnown method * separate conditionals in recomputeMetadata * separate conditionals in valuesUnknown
…1476) * Rename resolveChartName to buildChartNameWithRepository for clarity * Updating logs to reflect the new function name change
* Refactor: Rename struct fields in HelmReleaseModel to CamelCase * Fixing overlooked field, and making the struct names in alphabetical order
* remove m.Lock and more * fix recomputeMetadata logic * use count in concurrent testconfig * removal changes in helm directory concurrent test 2 * remove extra tests
…SingleNestedAttribute` (#1516) * initial refactor of metadata to be SingleNestedAttribute * fix unknown value error by using ObjectUnknown instead of ObjectNull() * update tests to align with SingleNested metadata attribute and not list
* initial refactoring of plan.lint with lintModifyPlan * replace tflog with diagnostics when cluster is unreachable * set state.Version as StringNull instead of plan.Version * Revert "initial refactoring of plan.lint with lintModifyPlan" This reverts commit 974fdeb.
Co-authored-by: John Houston <[email protected]>
jrhouston
force-pushed
the
helm-framework
branch
from
January 7, 2025 18:47
bd2670a
to
905cf39
Compare
jrhouston
force-pushed
the
supress-empty-description-test
branch
from
January 7, 2025 18:55
7bf0603
to
1e957a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds a test for the suppress empty description logic we have in place for the
Description
attributeWhen running the test, I am getting an weird error where after applying the first step, terraform still detects a change, which with my understanding means the suppression logic isn't taking affect as intended. I am not sure what the hiccup is, because after review the logic it looks perfectly fine to me! Can I get a second pair of eyes on this, there could be something I am not thinking of!
Logs from the test >
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note