templatefile variables need to be unmarked for TypeFunc
#36127
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The templatefile function actually calls the full renderer within the TypeFunc to determine what the resulting might be, but that also requires unmarking the top-level of the vars map to strip marks even though the value is unused.
jbardin
added
the
1.10-backport
liamcervante
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
templatefilefunction actually calls the full renderer within the TypeFunc to determine what the resulting type might be, but that also requires unmarking the top-level of the vars map to strip marks even though the value is unused.Fixes #36123
Target Release
v1.10.1
Draft CHANGELOG entry
BUG FIXES
templatefilepanics when given a sensitive or ephemeral collection of variables