-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc patch: link to ShortByteString from ByteString module #609
Conversation
I like the general idea. I'll try to leave some wordsmithery comments in the next day or two. |
85f1e08
to
b2b36b5
Compare
Hi @clyring, thanks for review. Suggestions taken, patch amended with rewords. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the high latency on this round of review.
No worries at all @clyring, thanks for getting back on this, appreciate the thoroughness. I'd responded in comments trying to clarify, and remain open for further suggestions. It's overall an intricate topic, but I think the docs here shouldn't elaborate all related technicalities; what remains is necessarily vague hinting at ideas, search keywords and such. I'll readily admit it's a fine balance, and won't dispute your perspective on which way to tilt it. So, by all means, smash the word anvil 😃 as you see fit. |
b2b36b5
to
8a72621
Compare
Took another stab at it, amended with minor tweaks + rebased onto latest master. |
Greetings all
Per the closed discussion in #193 — code-change won't be happening, but documentation may get improved.
Here I'm submitting a paragraph near the top of
Data.ByteString
module reiterating the points made inData.ByteString.Short
section on memory fragmentation. The idea is to simply advertiseShortByteString
from the package entry-point.Having been caught in this caveat myself — I can definitely reflect that the mention of
ShortByteString
from package header (cabal description), was hard to notice.@Bodigrim please review? Wording nitpicks, feedback, etc — totally welcome. Would appreciate an approve to merge, thanks in advance.