Convert display functions into Pretty instances
#10526
Open
+52
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of `showType` functions that are effectively a `Pretty` instance but less composable. Let's make them proper `Pretty` instances. Split off of haskell#10524
geekosaur
approved these changes
Nov 4, 2024
grayjay
reviewed
Nov 20, 2024
| deriving (Eq, Show, Generic) | ||
|
|
||
| -- | An implicit constraint added by Cabal. | ||
| | ConstraintSourceImplicit |
There was a problem hiding this comment.
It looks like this constructor is from #10524.
|
|
||
| -- | An implicit constraint added by Cabal. | ||
| | ConstraintSourceImplicit | ||
| deriving (Show, Eq, Ord, Generic, Typeable) |
There was a problem hiding this comment.
Are the Ord and Typeable instances from #10524?
| @@ -96,37 +93,35 @@ data PackageProperty | |||
| | PackagePropertySource | |||
| | PackagePropertyFlags FlagAssignment | |||
| | PackagePropertyStanzas [OptionalStanza] | |||
| deriving (Eq, Show, Generic) | |||
| deriving (Eq, Ord, Show, Generic) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of
showTypefunctions that are effectively aPrettyinstance but less composable. Let's make them properPrettyinstances.Split off of #10524