Skip to content

Expose combineAlways and hasLeadingPathSeparator #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 1.5.0.0
Choose a base branch
from
Open

Expose combineAlways and hasLeadingPathSeparator #97

wants to merge 2 commits into from

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Dec 3, 2021

Relevant: #49

@hasufell hasufell mentioned this pull request Dec 3, 2021
Open
@hasufell hasufell added this to the 1.5 milestone Dec 3, 2021
@hasufell hasufell changed the base branch from master to 1.5.0.0 December 3, 2021 17:07
@hasufell
Copy link
Member Author

hasufell commented Dec 3, 2021

Note this behavior:

-- > Posix:   "home" <\> "/bob" == "home//bob"

hasufell
hasufell commented Dec 3, 2021
View reviewed changes
System/FilePath/Internal.hs
Comment on lines +636 to +638
if hasLeadingPathSeparator x && not (isDrive x)
then let x' = dropWhile isPathSeparator x
in if null x' then [last x] else x'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
1 participant
@hasufell