Allow host_port to override the server_url from the JWT
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkaye97
changed the title
host_port to override the server_url from the JWT
mrkaye97
force-pushed
the
fixes-241
branch
2 times, most recently
from
863da2e
to
533e6b8
Compare
bugfix correct type hints for config init snake case tenant_id correctly override url in jwt add fallback server url move fallback to maintain something closer to current behavior unwind unwind drive by add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
A couple things here:
... | Noneto make a future type checker (+ my IDE) more happyhost_porttoNoneto make it more straightforward to check if it's set by the user or not. If it is, we use it to override the one set by the JWT, and if it's not, we fall back to the one from the JWT. Per @abelanger5 - seems like nobody is really using that default anyways