MyPy, Part II or III: Workflow metaclass
#274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: types for config, etc. * fix: queue type hint * fix: typeddict items
hatchet-temporary
added a commit
that referenced
this pull request
Dec 5, 2024
* feat: fix mypy for Workflow * fix: type stub * fix: remove any in a couple places * fix: attempting using `Union` * fix: try with `.Value` * fix: name attr * fix: remove more type: ignore * MyPy for Context, etc. (#276) * fix: types for config, etc. * fix: queue type hint * fix: typeddict items
hatchet-temporary
added a commit
that referenced
this pull request
Dec 6, 2024
…hers (#273) * fix: lint * feat: fixing mypy for the worker class * cleanup: print statements, unused imports * feat: exclude examples explicitly * chore: version * MyPy, Part II or III: `Workflow` metaclass (#274) * feat: fix mypy for Workflow * fix: type stub * fix: remove any in a couple places * fix: attempting using `Union` * fix: try with `.Value` * fix: name attr * fix: remove more type: ignore * MyPy for Context, etc. (#276) * fix: types for config, etc. * fix: queue type hint * fix: typeddict items * fix: install all the deps * fix: backoff factors * Feat: First Pass at Pydantic (#275) * fix: types for config, etc. * fix: typeddict items * feat: initial pass at pydantic support * fix: types * fix: test * fix: more types * debug: adding prints, fixing validator not present * fix: function sigs * fix: typed dict key * fix: comment * feat: clean up validators * cleanup: import * cleanup: type hint improvements * feat: add simple example * feat: type casts * fix: tests and example * fix: worker fixture * fix: deprecation warning for overrides * feat: try out using a validator registry, part I * feat: validator registry, part ii * feat: clean up pydantic example * fix: tests and lint * fix: one more type cast * cleanup: cruft and print statements * fix: worker input val and validator key * feat: expand tests a little * fix: more typing * feat: documentation updates for Pydantic * cleanup: cruft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyPy fixes for the
Workflowmetaclass and some downstream usage with a protocol