-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest Tweaks, Part III - Test Isolation #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pytest.mark.skip(reason="The timing for this test is not reliable") | ||
@pytest.mark.asyncio(scope="session") | ||
async def test_run(aiohatchet: Hatchet): | ||
async def test_run(aiohatchet: Hatchet, worker): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to explicitly request the fixture now
|
||
|
||
# requires scope module or higher for shared event loop | ||
@pytest.mark.parametrize("worker", ["concurrency_limit_rr"], indirect=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parametrizing the fixture with the example to run
abelanger5
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking the
bg_worker
fixture to:autouse
d (it needs to be requested now)I was seeing some weird failures in CI that were indicating that there was leakage between the tests, and this seemed like a pretty obvious possible culprit. I think what was happening was the fixtures were being spun up but not torn down, so if (e.g.) two workflows had the same name, that could cause problems