Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fxlogin: Send an extra <ENTER> before exit to fix FXOS + ASA backups #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mstefani
Copy link

@mstefani mstefani commented Jan 7, 2025

The issue is in the fxos.pm module though:

sub WriteTerm {
...
while (<$INPUT>) {
...
return(0) if ($found_end); # Only do this routine once

WriteTerm() eats another line even though it found the end of the show config command

And that line is

fw01-dist-3a-z-fx# exit

The exact same line that the inloop() function looks for to detect that we had a clean run.

The issue was reported before on the mailing list https://shrubbery.net/pipermail/rancid-discuss/2020-October/010985.html

The issue is in the fxos.pm module though:

    sub WriteTerm {
    ...
    while (<$INPUT>) {
    ...
    return(0) if ($found_end); # Only do this routine once

WriteTerm() eats another line even though it found the end of the show
config command

And that line is

    fw01-dist-3a-z-fx# exit

The exact same line that the inloop() function looks for to detect that
we had a clean run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant