-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cover art download #53
base: master
Are you sure you want to change the base?
Conversation
Fix cover art download PR hbashton#53
I got this error message returned after the download is complete (before tagging the audio file):
|
@adan89lion Are you sure spotify-ripper is running on python 2.7? This is common error if you're on python 3+, since it has split |
@pauloup Seems like it! Thanks (I thought this python script is compatible with the python 3 version of the ripper). |
@adan89lion To make this python 3 compatible, just replace "urllib" by "urllib.request" in the two instances it appears in tags.py |
I just wanted to install this fix, and replaced the tags.py in spotify-ripper/spotify_ripper. But it seams that this is the wrong place as it makes no difference. Even when I rename the tags.py spotify-ripper is still running as before. |
I just updated the file |
@pauloup Thank you for this fix!! I was going crazy about the cover download function not working anymore! |
I've made some changes to tags.py and fixed the cover art download bug #51.
The bug seemed to be in the
image.load
function in the main spotify library. It returns True but no data is getting loaded. So I replaced it by aurllib.urlretrieve
call that saves the cover art to a temp file, and retrieves the data in a variableimage
.I also changed the cover url to get the higher resolution available (640px for now) using the
track.album.cover(2)
option.Please let me know if there is any issue.