-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chains to replace site:mode command #3541
Comments
Another proof of concept: Use twig + a new command to override services. File: chain-site-mode.yml
The if/else is not working, I think I am using an invalid syntax |
@marcelovani could you try using as :
or
|
Ok, try this It works fine but the chain looks cluttered with all the twig stuff, I think its neater if we do the chain as per #3540 Testing: Todo:
|
Issue title
[site:mode] Use chains to replace site:mode command
Problem/Motivation
Since chains are getting more powerful, I figured we could replace the code found in https://github.com/hechoendrupal/drupal-console/blob/master/src/Command/Site/ModeCommand.php with a chain
Details to include:
We can simply have less code to maintain and add more flexibility to users
Solution
https://github.com/hechoendrupal/drupal-console/blob/master/src/Command/Site/ModeCommand.php and the actual site.mode.yml
This is how the site:mode:dev chain would look
The prod chain would be the inverse of the chain above
This chain should appear only when there is a site installed, that would automatically happen when we implement hechoendrupal/drupal-console-core#240
The text was updated successfully, but these errors were encountered: