Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3541 Removed site:mode command, Added service:override command #3771

Closed

Conversation

marcelovani
Copy link
Member

No description provided.

@jmolivas jmolivas added this to the 1.6.1 milestone Feb 14, 2018
@jmolivas jmolivas modified the milestones: 1.7.0, 1.8.0 Mar 6, 2018
@jmolivas jmolivas modified the milestones: 1.8.0, 1.9.0 Apr 22, 2018
@enzolutions
Copy link
Contributor

@marcelovani Muito Obrigado.

We want to include this in the new version, could you include more information about why we need to remove the site:mode and how service:override will replace this command in a more effective way.

Thanks in advance.

Muito Obrigado

@marcelovani
Copy link
Member Author

This pr is for this issue #3541
I did this a long time ago and I can't remember the whole thinking behind it, but I think the idea was to use the service:override to replace existing logic in the site:mode command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants