-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Use composers autoloader for path retrieval #2750
base: master
Are you sure you want to change the base?
Conversation
I like the idea! |
This is blocked by the facet that DrupalConsole, drupal-console-core and drupal-console-launcher use the same PSR-4 namespace. They have to use different namespaces. @jmolivas Can we change drupal-console-core to Drupal\ConsoleCore and drupal-console-launcher to Drupal\ConsoleLauncher? |
I like the idea @webflo |
@webflo What is the reason for renaming the namespace, if this is the case we will need to change code in core and contrib commands, may we search for another option? |
Composer uses the namespace as array key in its PRS-4 autoload (look at an composer/autoload_psr4.php). It will only use DrupalConsole or drupal-console-core. You can't have both in one project. It fails if you try to pull both as dependency in your project. |
I think its safe to start with the launcher. This component is separate, the change is easy. We have to do more planning for the other ones. |
Namespaces updated
|
@webflo We changed the constant definition extending https://github.com/hechoendrupal/drupal-console-core/blob/master/src/Utils/DrupalFinder.php#L26-L40 Do you think his fixes the reported issue? |
@webflo this idea is still valid, thanks in advance for any comment in regards to it. |
No description provided.