Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chassis platforms cleanup #1156

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Chassis platforms cleanup #1156

wants to merge 24 commits into from

Conversation

AYadrov
Copy link
Contributor

@AYadrov AYadrov commented Mar 3, 2025 •
edited
Loading

This PR introduces the following updates:

  • Adding a herbie10 platform with costs 0 for all the operations/literals,
  • Adding a herbie20 platform that is currently is default of main,
  • Making libm platform to be a new default platform,
  • Adding 32bit operations to libm platform with corresponding costs,
  • Removing no-pareto mode, because it should match herbie10 platform at this point,
  • Removing some additional globals as *egraph-platform-cost* since not used anymore,
  • Making extraction based on the platform costs by default

AYadrov added 17 commits February 25, 2025 13:29
@AYadrov
added old cost model as herbie10
4c23cd2
@AYadrov
report fixed when cost is equal to zero
75ef187
@AYadrov
herbie10 as a default platform to check results on nightly
aff6449
@AYadrov
Merge branch 'main' into chassis-platforms-cleanup
0bdd419
@AYadrov
unit tests check
4e07c0d
@AYadrov
default platform renamed to herbie20
81a02ac
@AYadrov
oops, added herbie20.rkt to github
39784a2
@AYadrov
generation page script fix
725dc72
@AYadrov
herbie20 now being default platform to pass integration tests
3f31581
@AYadrov
added binary32 operations to libm
5f0d708
@AYadrov
tracked down differences with no-pareto and herbie10 platform. now ni…
d498655 
…ghtly should produce the same results
@AYadrov
default->herbie10 at some benchmarks
839f856
@AYadrov
flags to match no-pareto mode
e7100f6
@AYadrov
some extremely crazy typos
3ad4492
@AYadrov
that was a mistake to put these flags on nightly
baff567
@AYadrov
removed no-pareto and egraph-platform-cost
c0874f5
@AYadrov
default platform set to be c
3e24234
@AYadrov AYadrov requested a review from pavpanchekha March 3, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavpanchekha pavpanchekha Awaiting requested review from pavpanchekha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AYadrov