chore (pnpm clean) - rimraf Instead of rm for Windows OS Support
#2443
Conversation
replace `rm` with rimraf while deleting node_modules during `pnpm clean` to support in both Windows and Linux.
|
|
@alphaxek is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alphaxek
changed the title
rimraf Instead of rm for Windows OS Supportrimraf Instead of rm for Windows OS Support
| @@ -37,7 +37,7 @@ | |||
| "turbo:clean": "turbo clean && rimraf ./node_modules/.cache/turbo", | |||
| "turbo:graph": "pnpm build --graph=dependency-graph.png", | |||
| "clean": "pnpm turbo:clean && pnpm clean:jest && pnpm clean:node-modules && pnpm clean:lock && pnpm install --hoist", | |||
| "clean:node-modules": "rimraf ./apps/**/node_modules && rimraf ./packages/**/**/node_modules && rm -rf ./node_modules", | |||
| "clean:node-modules": "rimraf ./apps/**/node_modules && rimraf ./packages/**/**/node_modules && rimraf ./node_modules", | |||
| "clean:changelogs": "rimraf ./packages/**/**/CHANGELOG.md", | |||
| "clean:lock": "rm ./pnpm-lock.yaml", | |||
There was a problem hiding this comment.
clean:lock This should also be modified
There was a problem hiding this comment.
Thank you @Simon-He95 for you review.
|
Thank you @wingkwong for you review. |
replace
rmwith rimraf while deleting node_modules duringpnpm cleanto support in both Windows and Linux.Closes #2442
📝 Description
Replace
rm -rfwithrimrafin[pnpm clean](clean:node-modules)in root package.json scripts.⛳️ Current behavior (updates)
[pnpm clean](clean:node-modules)script used fornode_modulescleaning doesn't work in Windows OS asrmcommand is not internal.🚀 New behavior
Deletes root
node_modulesin Windows OS as well withrimraf.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
NA