Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pnpm:lock script): rimraf for windows support #2454

Merged

Conversation

alphaxek
Copy link
Contributor

@alphaxek alphaxek commented Mar 5, 2024

replaced rm with rimraf in pnpm:lock in root package.json to support windows

Closes #2453

📝 Description

Replace rm with rimraf in pnpm clean in root package.json script.

⛳️ Current behavior (updates)

[pnpm clean](clean:lock) script used for pnpm-lock.yaml cleaning doesn't work in Windows OS as rm command is not internal.

🚀 New behavior

Deletes root pnpm-lock.yaml in Windows OS as well with rimraf.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No

replaced `rm` with `rimraf` in `pnpm:lock` in root package.json to support windows
@alphaxek alphaxek requested a review from jrgarciadev as a code owner March 5, 2024 22:55
Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: dd5f957

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 10:58pm

Copy link

vercel bot commented Mar 5, 2024

@alphaxek is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@jrgarciadev jrgarciadev merged commit f220564 into heroui-inc:main Mar 5, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] - rimraf Instead of rm for Windows OS Support
2 participants