fix(breadcrumbs): add RTL support to the breadcrumbs component (#2486) #2487
Conversation
🦋 Changeset detectedLatest commit: e120f30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
mrbadri
force-pushed
the
fix/breadcrumbs
branch
from
b6c92c2 to
e120f30
Compare
Hi alphaxek, I have resolved this issue with commit e120f30. return (
<NextUIProvider locale={locale}>
<div className="bg-dark" lang={locale} dir={direction}>
<Story />
</div>
</NextUIProvider>
// Modal component renders here
// Tooltips component renders here
);The direction in the root div does not affect the tooltip and modal, so we must change the direction in the body CSS. |
|
@mrbadri thanks! Ref: |
| @@ -14,7 +14,11 @@ const Breadcrumbs = forwardRef<"div", BreadcrumbsProps>((props, ref) => { | |||
| children, | |||
| childCount, | |||
| itemProps, | |||
| separator = <ChevronRightIcon />, | |||
| separator = ( | |||
| <div className="rtl:transform rtl:rotate-180"> | |||
There was a problem hiding this comment.
@mrbadri all the tailwindcss styles should be in the theme package, this is because the users load the styles only from that folder https://nextui.org/docs/guide/installation#tailwind-css-setup so all tailwindcss classes out of there will not be compiled
|
@wingkwong any update on this? when it's expected to go live? |
|
Closing - inactivity. |
Closes #2486
📝 Description
Add RTL support to the breadcrumbs component.
⛳️ Current behavior (updates)
he breadcrumbs component currently lacks support for right-to-left (RTL) direction.
🚀 New behavior
This PR addresses the RTL support issue in the breadcrumbs component, ensuring correct rendering in RTL environments.
💣 Is this a breaking change (Yes/No):
📝 Additional Information