fix(table): hide empty content if isLoading is true (#2470)

[brunokc]

Closes #2470

📝 Description

This change ensures that emptyContent is hidden if isLoading is true

⛳️ Current behavior (updates)

Currently, if loadingContent and emptyContent are both provided, and isLoading is true, NextUI will render both of them on top of each other.

🚀 New behavior

This change suppresses the rendering of emptyContent if isLoading is true.

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

Note that there's an existing issue with loadingContent where if emptyContent is not provided, NextUI will render loadingContent on top of the columns (instead of inside the table). This change doesn't fix that, but rather make isLoading/loadingContent play nice with a provided emptyContent. A separate fix is still needed for when emptyContent is not provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ad15d05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 10, 2024 1:47am

[vercel]

@brunokc is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[brunokc]

Hi @jrgarciadev @tianenpang @wingkwong,

This change seems to be enough for isLoading and emptyContent to play nice in my scenario, where both are supplied. However, I had to change my original fix so that loadingContent renders in the right place (inside the table instead of on top of the columns), but that only works if emptyContent is provided.

I'm not sure this is acceptable. I intended to fix the "loadingContent without emptyContent" rendering issue but I don't know enough about the framework to propose a fix. I'd be happy to follow your guidance and try to fix it, if you have any suggestions.

[jrgarciadev]

Thank you! @brunokc

[alphaxek]

Hi @jrgarciadev @tianenpang @wingkwong,

This change seems to be enough for isLoading and emptyContent to play nice in my scenario, where both are supplied. However, I had to change my original fix so that loadingContent renders in the right place (inside the table instead of on top of the columns), but that only works if emptyContent is provided.

I'm not sure this is acceptable. I intended to fix the "loadingContent without emptyContent" rendering issue but I don't know enough about the framework to propose a fix. I'd be happy to follow your guidance and try to fix it, if you have any suggestions.

I will raise PR for this