feat(table spinner): Fixed Spinner without emptyContent prop in Table #2500

alphaxek · 2024-03-10T21:48:51Z

Fixed Spinner loading on top of columns in case of emptyContent prop not passed to Table.

Closes #2499

📝 Description

Fixed the Spinner loading on top of columns instead of inside table in case of emptyContent prop not passed to Table.

⛳️ Current behavior (updates)

Spinner loading on top of columns instead of inside table in case of emptyContent prop not passed to Table.

🚀 New behavior

Spinner loading inside Table in case of emptyContent prop not passed to Table.

Test:

<Table aria-label="Example empty table" {...args}>
  <TableHeader>
    <TableColumn>NAME</TableColumn>
    <TableColumn>ROLE</TableColumn>
    <TableColumn>STATUS</TableColumn>
  </TableHeader>
  <TableBody isLoading loadingContent={<Spinner label="Loading..." />}>
    {[]}
  </TableBody>
</Table>

Test Visual:

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No

Summary by CodeRabbit

Bug Fixes
- Fixed the Spinner loading issue in TableBody when emptyContent prop is not provided, ensuring an empty table cell is displayed correctly.

Fixed Spinner loading on top of columns in case of emptyContent prop not passed.

changeset-bot · 2024-03-10T21:48:55Z

🦋 Changeset detected

Latest commit: ad65585

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/table	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-03-10T21:48:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2024 2:28pm

coderabbitai · 2024-03-10T21:48:57Z

Warning

Rate Limit Exceeded

@alphaxek has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 6 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 790b97b and ad65585.

Walkthrough

The new file introduces a patch update for @nextui-org/table to address the bug where the Loader incorrectly loads on top of columns when emptyContent is not provided. The fix involves adding conditional rendering logic in the TableBody component to ensure the Loader appears inside the table as expected, enhancing the visual presentation and user experience.

Changes

File Path	Change Summary
`.changeset/nice-rockets-watch.md`	Introduced patch update to fix Spinner loading issue and added conditional rendering logic.
`.../components/table/src/table-body.tsx`	Implemented logic to display an empty table cell based on the `emptyContent` condition.

Assessment against linked issues

Objective	Addressed	Explanation
[BUG] - `Loader` Loads on Top of Columns (#2499)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

vercel · 2024-03-10T21:48:57Z

@alphaxek is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 5a8768a and ffccd54.

Files selected for processing (2)

.changeset/nice-rockets-watch.md (1 hunks)
packages/components/table/src/table-body.tsx (1 hunks)

Additional comments: 1

packages/components/table/src/table-body.tsx (1)

124-124: The addition of an empty table cell when isLoading is true and emptyContent is not provided is a good fix for the issue. However, it's important to verify this behavior across different scenarios to ensure it works as intended without introducing any unintended side effects.

.changeset/nice-rockets-watch.md

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between ffccd54 and fe22bac.

Files selected for processing (1)

.changeset/nice-rockets-watch.md (1 hunks)

.changeset/nice-rockets-watch.md

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between fe22bac and 790b97b.

Files selected for processing (1)

.changeset/nice-rockets-watch.md (1 hunks)

.changeset/nice-rockets-watch.md

jrgarciadev

Thank you! @alphaxek

feat(table spinner): spinner without emptyContent

ffccd54

Fixed Spinner loading on top of columns in case of emptyContent prop not passed.

alphaxek requested a review from jrgarciadev as a code owner March 10, 2024 21:48

vercel bot deployed to Preview – nextui-storybook-v2 March 10, 2024 21:51 View deployment

coderabbitai bot reviewed Mar 10, 2024

View reviewed changes

.changeset/nice-rockets-watch.md Outdated Show resolved Hide resolved

Update .changeset/nice-rockets-watch.md

fe22bac

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

vercel bot deployed to Preview – nextui-storybook-v2 March 10, 2024 21:58 View deployment

coderabbitai bot reviewed Mar 10, 2024

View reviewed changes

wingkwong requested changes Mar 11, 2024

View reviewed changes

.changeset/nice-rockets-watch.md Outdated Show resolved Hide resolved

alphaxek added 2 commits March 11, 2024 11:24

fix(table spinner): changeset fix

790b97b

fix(table spinner): changeset description fix

ad65585

coderabbitai bot reviewed Mar 11, 2024

View reviewed changes

.changeset/nice-rockets-watch.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview – nextui-storybook-v2 March 11, 2024 14:19 View deployment

vercel bot deployed to Preview – nextui-storybook-v2 March 11, 2024 14:28 View deployment

jrgarciadev approved these changes Mar 16, 2024

View reviewed changes

jrgarciadev merged commit ea48ac2 into heroui-inc:main Mar 16, 2024
7 of 8 checks passed

This was referenced Mar 16, 2024

ci(changesets): 📦 version packages #2441

Merged

ci(changesets): 📦 version packages hoanghohotel/nextui#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(table spinner): Fixed Spinner without emptyContent prop in Table #2500

feat(table spinner): Fixed Spinner without emptyContent prop in Table #2500

alphaxek commented Mar 10, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 10, 2024 •

edited

Loading

vercel bot commented Mar 10, 2024 •

edited

Loading

coderabbitai bot commented Mar 10, 2024 •

edited

Loading

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

vercel bot commented Mar 10, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

jrgarciadev left a comment

feat(table spinner): Fixed Spinner without emptyContent prop in Table #2500

feat(table spinner): Fixed Spinner without emptyContent prop in Table #2500

Conversation

alphaxek commented Mar 10, 2024 • edited by coderabbitai bot Loading

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

changeset-bot bot commented Mar 10, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Mar 10, 2024 • edited Loading

coderabbitai bot commented Mar 10, 2024 • edited Loading

Rate Limit Exceeded

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

vercel bot commented Mar 10, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

jrgarciadev left a comment

Choose a reason for hiding this comment

alphaxek commented Mar 10, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 10, 2024 •

edited

Loading

vercel bot commented Mar 10, 2024 •

edited

Loading

coderabbitai bot commented Mar 10, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)