Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(disabled table rows): fixed cursor for disabled rows in Table #2502

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

alphaxek
Copy link
Contributor

@alphaxek alphaxek commented Mar 10, 2024

Fixed cursor for disabled rows in Table rows .

Closes #2501

📝 Description

Fixed the normal cursor to cursor-not-allowed for disabled rows in Table.

⛳️ Current behavior (updates)

Normal cursor shows for disabled rows in Table.

tableCursor

🚀 New behavior

cursor-not-allowed shows for disabled rows in Table.

tableCursor1

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced user experience by updating the cursor style for disabled rows in the Table component.

Fixed cursor for disabled rows in Table rows .
@alphaxek alphaxek requested a review from jrgarciadev as a code owner March 10, 2024 23:24
Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 2:10pm

Copy link

changeset-bot bot commented Mar 10, 2024

🦋 Changeset detected

Latest commit: 7489007

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/table Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 10, 2024

@alphaxek is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Mar 10, 2024

Walkthrough

The update introduces a patch to improve user interaction by setting the cursor style to "cursor-not-allowed" for disabled rows in the NextUI Table component, rectifying the issue where a normal cursor was displayed for disabled rows.

Changes

File Path Change Summary
.changeset/mighty-hornets-destroy.md Introduced a patch update fixing the cursor style to "cursor-not-allowed" for disabled rows in the Table component.
packages/.../src/components/table.ts Modified cursor style to "cursor-not-allowed" for disabled rows.

Assessment against linked issues

Objective Addressed Explanation
Show cursor-not-allowed for disabled rows (#2501)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 5a8768a and 772a93b.
Files selected for processing (2)
  • .changeset/mighty-hornets-destroy.md (1 hunks)
  • packages/core/theme/src/components/table.ts (1 hunks)
Additional comments: 2
.changeset/mighty-hornets-destroy.md (1)
  • 1-5: The changeset file accurately describes the major version change for the "@nextui-org/table" package, clearly communicating the nature of the fix implemented. This is an appropriate categorization given the potential impact on user experience.
packages/core/theme/src/components/table.ts (1)
  • 105-105: The addition of the "group-data-[disabled=true]:cursor-not-allowed" style for disabled rows in the Table component is a direct and effective implementation of the PR's objective. This change enhances user experience by providing a clearer visual cue that these rows are not interactive.

.changeset/mighty-hornets-destroy.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 772a93b and 7489007.
Files selected for processing (1)
  • .changeset/mighty-hornets-destroy.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .changeset/mighty-hornets-destroy.md

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @alphaxek

@jrgarciadev jrgarciadev merged commit b0ee8e3 into heroui-inc:main Mar 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Disabled Rows in Table Shows Normal Cursor
3 participants