-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(disabled table rows): fixed cursor for disabled rows in Table #2502
fix(disabled table rows): fixed cursor for disabled rows in Table #2502
Conversation
Fixed cursor for disabled rows in Table rows .
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7489007 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@alphaxek is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe update introduces a patch to improve user interaction by setting the cursor style to "cursor-not-allowed" for disabled rows in the NextUI Table component, rectifying the issue where a normal cursor was displayed for disabled rows. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- .changeset/mighty-hornets-destroy.md (1 hunks)
- packages/core/theme/src/components/table.ts (1 hunks)
Additional comments: 2
.changeset/mighty-hornets-destroy.md (1)
- 1-5: The changeset file accurately describes the major version change for the "@nextui-org/table" package, clearly communicating the nature of the fix implemented. This is an appropriate categorization given the potential impact on user experience.
packages/core/theme/src/components/table.ts (1)
- 105-105: The addition of the "group-data-[disabled=true]:cursor-not-allowed" style for disabled rows in the Table component is a direct and effective implementation of the PR's objective. This change enhances user experience by providing a clearer visual cue that these rows are not interactive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- .changeset/mighty-hornets-destroy.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .changeset/mighty-hornets-destroy.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @alphaxek
Fixed cursor for disabled rows in Table rows .
Closes #2501
📝 Description
Fixed the normal cursor to
cursor-not-allowed
fordisabled
rows in Table.⛳️ Current behavior (updates)
Normal cursor shows for disabled rows in Table.
🚀 New behavior
cursor-not-allowed
shows for disabled rows in Table.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
No
Summary by CodeRabbit