-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(use-image): set status after hydrated #4486
Conversation
🦋 Changeset detectedLatest commit: e1cc1d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces modifications to the Changes
Sequence DiagramsequenceDiagram
participant Component as React Component
participant UseImageHook as useImage Hook
participant ImageLoader as Image Loader
Component->>UseImageHook: Initialize with props
UseImageHook->>UseImageHook: Set initial status to "pending"
Note over UseImageHook: Hydration check
UseImageHook->>ImageLoader: Determine initial status
ImageLoader-->>UseImageHook: Return status
UseImageHook->>Component: Update status after hydration
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closes #
📝 Description
follow-up of #4442
⛳️ Current behavior (updates)
The status was not set after hydrated in previous version. Therefore, the image is not loaded even hydrated.
🚀 New behavior
Update the status once it's hydrated
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
@nextui-org/use-image
to address potential rendering inconsistencies.Chores