fix(theme): input height in innerWrapper in Select

[ShrinidhiUpadhyaya]

Closes #4321

📝 Description

• Changed the input height from h-full to h-fit

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• Bug Fixes

  • Fixed an issue with input height in the NextUI Select component.
  • Adjusted inner wrapper styling to prevent clipping of the label.

• Refactor

  • Updated type definitions for Select component variants and slots.

[changeset-bot]

🦋 Changeset detected

Latest commit: 19f9963

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@ShrinidhiUpadhyaya is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Warning

Rate limit exceeded

@wingkwong has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4122f44 and 19f9963.

📒 Files selected for processing (1)

• .changeset/tiny-schools-hang.md (1 hunks)

Walkthrough

A patch has been introduced for the @nextui-org/theme package to address an input height issue. The change specifically modifies the innerWrapper slot's style in the select component, changing the height property from h-full to h-fit. This adjustment aims to resolve placeholder misalignment in multi-select dropdowns with chips, potentially improving the component's rendering and layout behavior.

Changes

File	Change Summary
packages/core/theme/src/components/select.ts	- Modified innerWrapper slot style from h-full to h-fit - Updated type exports for SelectVariantProps, SelectSlots, and select
.changeset/tiny-schools-hang.md	Patch file for the @nextui-org/theme package

Assessment against linked issues

Objective	Addressed	Explanation
Resolve placeholder misalignment in multi-select dropdown [#4321]	✅
Fix height-related styling for dropdown with isMultiline={true} [#4321]	✅

Possibly related PRs

• fix(components): improve RTL support for select component #2041: This PR enhances the RTL support for the select component, which is relevant as the main PR also modifies the select component's styling.
• fix(theme): fixing the label placement in select and input #3869: This PR addresses label placement in the select component, which is directly related to the changes in the main PR that modify the select component's structure and styling.
• fix(theme): make select styles consistent with input #3881: This PR focuses on making the select styles consistent with the input component, which aligns with the main PR's modifications to the select component's styling.
• fix: input in card becomes invisible on hover and making date-input and time-input consistent #4394: This PR fixes the visibility issue of the input within a card, which is relevant as it also pertains to input components, including select inputs, and addresses consistency in appearance.

Suggested labels

👀 Status: To Review

Suggested reviewers

• wingkwong
• jrgarciadev

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[wingkwong]

can you also provide the code you used in the screenshot?

[wingkwong]

You only modified theme so please change to @nextui-org/theme

[ShrinidhiUpadhyaya]

can you also provide the code you used in the screenshot?

it is With Chips template in stories with labelPlacement="inside"