fix(theme): sync with input theme on labelPlacement

[wingkwong]

Closes #4593

📝 Description

align the label center with the input

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• New Features

  • Enhanced select component styling and layout
  • Improved label placement functionality

• Bug Fixes

  • Resolved theme inconsistencies with input label placement

• Chores

  • Updated dependency @heroui/theme
  • Adjusted select component layout in stories

• Style

  • Modified maximum width for select component display
  • Added flexible layout classes for label and helper text

[linear]

ENG-1908 [BUG] - Select with outside-left label placement is not aligned with label

[changeset-bot]

🦋 Changeset detected

Latest commit: be3b0d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@heroui/theme	Patch
@heroui/autocomplete	Patch
@heroui/checkbox	Patch
@heroui/date-input	Patch
@heroui/date-picker	Patch
@heroui/form	Patch
@heroui/input-otp	Patch
@heroui/input	Patch
@heroui/radio	Patch
@heroui/select	Patch
@heroui/table	Patch
@heroui/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 19, 2025 5:11am
heroui-sb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 19, 2025 5:11am

[coderabbitai]

Walkthrough

The pull request addresses alignment and styling issues for select components with outside-left label placement. Changes include updates to the theme configuration in the select.ts file, modifying layout classes to improve responsiveness and alignment. A patch for the "@heroui/theme" dependency is introduced, and the select stories file is updated with wider maximum width for component layouts.

Changes

File	Change Summary
.changeset/serious-sheep-camp.md	Patch update for @heroui/theme dependency
packages/components/select/stories/select.stories.tsx	Increased max-width from max-w-2xl to max-w-5xl for select component divs
packages/core/theme/src/components/select.ts	Added flex-shrink-0 to label, updated conditional classes for helper wrapper and label placement

Assessment against linked issues

Objective	Addressed	Explanation
Align select with outside-left label placement	✅
Fix layout issues with helper text	✅

The changes directly address the alignment and layout concerns raised in issue #4593, specifically improving the positioning of select components with outside-left label placement and handling of helper text.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 103519c and be3b0d4.

📒 Files selected for processing (3)

• .changeset/serious-sheep-camp.md (1 hunks)
• packages/components/select/stories/select.stories.tsx (3 hunks)
• packages/core/theme/src/components/select.ts (4 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/components/select/stories/select.stories.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: TypeScript
• GitHub Check: Build

🔇 Additional comments (5)

packages/core/theme/src/components/select.ts (4)

14-14: Good addition of flex-shrink-0 to prevent label compression.

This change ensures the label maintains its width and doesn't get compressed when space is limited.

---

33-33: Improved helper text layout with conditional flex display.

The conditional class group-data-[has-helper=true]:flex ensures proper layout when helper text is present.

---

147-147: Enhanced outside-left label alignment with helper text support.

The updated base class properly handles alignment both with and without helper text:

• flex-row and items-center for default alignment
• data-[has-helper=true]:items-start for proper alignment with helper text

---

723-744: Well-structured compound variants for different sizes.

The new compound variants handle padding adjustments for different sizes (sm, md, lg) when helper text is present, ensuring consistent alignment across all size variants.

.changeset/serious-sheep-camp.md (1)

1-5: Appropriate versioning and clear change description.

The changeset correctly:

• Uses patch version for non-breaking changes
• References the issue ([BUG] - Select with outside-left label placement is not aligned with label #4593)
• Provides a clear description of the change purpose

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ryo-manba]

LGTM, thank you!