-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade hcloud-go to v2 #1062
Open
jooola
wants to merge
11
commits into
main
Choose a base branch
from
upgrade-hcloud-go-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 66.53% 66.39% -0.14%
==========================================
Files 67 69 +2
Lines 9947 9916 -31
==========================================
- Hits 6618 6584 -34
- Misses 2614 2618 +4
+ Partials 715 714 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jooola
force-pushed
the
upgrade-hcloud-go-v2
branch
2 times, most recently
from
January 9, 2025 20:35
20a339d
to
73b3094
Compare
jooola
force-pushed
the
upgrade-hcloud-go-v2
branch
from
January 10, 2025 10:59
73b3094
to
820d07c
Compare
jooola
force-pushed
the
upgrade-hcloud-go-v2
branch
from
January 10, 2025 15:04
820d07c
to
1699bef
Compare
jooola
force-pushed
the
upgrade-hcloud-go-v2
branch
from
January 20, 2025 14:44
0551552
to
3f36288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to migrate the hcloud-go library to v2, to be able to finally drop the v1 version.
We previously discussed of not going this route, but the effort of porting new features in both hcloud-go versions is bigger than upgrade the library in the terrafrom plugin.
If this change ends up being impossible to test and too dangerous, we will just continue the route we initially choose: migrating for to the plugin framework then the hcloud-go library.
Fix #877