Several bugfixes and improvements #7
+32
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `ValueError: Incorrect label count`
This fixes `TypeError: unhashable type: 'list'`
This improves the cache utilization and speeds up development cycles
This app is mostly run in a container in k8s. Running it with the process manager of gunicorn and a single uvicorn worker is not only unnecessary, but also makes signal handling slightly worse (e.g. SIGINT directly terminates uvicorn, but takes much longer in gunicorn). It can also lead to a semi-healthy state, where the uvicorn worker is crashing, but the gunicorn process just spawns a new one, without surfacing the issue. See also https://fastapi.tiangolo.com/deployment/docker/#replication-number-of-processes
When an exception occurs within an asyncio task, this doesn't interrupt the main flow. This means that exceptions never surfaced and the webserver continued to serve metrics, although they might not have been updated anymore. This wrapper catches any exception, logs it and then calls `sys.exit(1)`, so that the orchestrator (e.g. k8s) can recycle the container, allowing observability tools to notice that there is something wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of several changes, see list below and individual commit messages. If you want any of them not to be included (or pushed to a separate PR), please let me know!