HHH-11866 fix CustomEntityDirtinessStrategy#resetDirty is not called after entity initialization #10218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbladel
reviewed
May 26, 2025
There was a problem hiding this comment.
Thanks @peter1123581321, your changes look good. Left a few minor comments
hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/dirtiness/HHH11866Test.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
May 26, 2025
peter1123581321
force-pushed
the
HHH-11866
branch
from
1fdaacb to
a6ef23c
Compare
gavinking
reviewed
May 27, 2025
hibernate-core/src/main/java/org/hibernate/engine/internal/EntityEntryImpl.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
May 27, 2025
hibernate-core/src/main/java/org/hibernate/engine/internal/EntityEntryImpl.java
Outdated
Show resolved
Hide resolved
peter1123581321
force-pushed
the
HHH-11866
branch
2 times, most recently
from
8b1c8ce to
cef2a17
Compare
gavinking
reviewed
May 27, 2025
hibernate-core/src/main/java/org/hibernate/engine/internal/EntityEntryImpl.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
mbladel
approved these changes
May 27, 2025
There was a problem hiding this comment.
@peter1123581321 this looks good, please squash everything to a single commit.
Since the fix depends on #10226 we won't be back-porting it.
…after entity initialization
peter1123581321
force-pushed
the
HHH-11866
branch
from
780f511 to
a42e181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a CustomEntityDirtinessStrategy leads to entities marked as dirty after they have been first loaded.
Consequently, calling flush immediately afterwards leads to an update, although the entity has not been changed.
The fix added a call of CustomEntityDirtinessStrategy#resetDirty in AbstractEntityPersister#afterInitialize.
The fix also needed a change of two assertions in CustomDirtinessStrategyTest, but they are ok.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-11866