Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

carlblan · 2025-07-08T21:48:41Z

Some updates from an Oracle employee to the Oracle TimesTen Community dialect. ( Hibernate 6.6 )

In TimesTenDialect.java

Adding more datatypes into columnType()
Added more SQL functions support into initializeFunctionRegistry()
Updated the custom definition for 'getForUpdateString()'
Added a custom definition for 'getNativeIdentifierGeneratorStrategy()'
Added a custom definition for 'currentDate()'
Added a custom definition for 'currentTime()'
Added a custom definition for 'getMaxVarcharLength()'
Added a custom definition for 'getMaxVarbinaryLength()'
Added a custom definition for 'isEmptyStringTreatedAsNull()'
Added a custom definition for 'supportsTupleDistinctCounts()'
Added a custom definition for 'getDual()'
Added a custom definition for 'getFromDualForSelectOnly()'

In TimesTenSqlAstTranslator.java

Added a custom definition for 'renderRowsToClause()'

In TimesTenLimitHandler.java

    The class now extends 'AbstractLimitHandler'
    Removed a custom definition for 'insert()'
    Added a custom definition for 'supportsLimit()'
    Added a custom definition for 'supportsOffset()'
    Added a custom definition for 'supportsLimitOffset()'
    Added a custom definition for 'supportsVariableLimit()'
    Added a custom definition for 'convertToFirstRowValue(int zeroBasedFirstResult)'
    Added a custom definition for 'useMaxForLimit()'
    Added a custom definition for 'limitClause(boolean hasFirstRow)'

In TimesTenSequenceSupport.java

    The Class now implements 'SequenceSupport'
    Added a custom definition for 'supportsSequences()'
    Added a custom definition for 'supportsPooledSequences()'
    Added a custom definition for 'getSelectSequenceNextValString(String sequenceName)'
    Added a custom definition for 'getSequenceNextValString(String sequenceName)'
    Added a custom definition for 'getCreateSequenceString(String sequenceName)'
    Added a custom definition for 'getDropSequenceString(String sequenceName)'

Testing:

The changes were tested with some local tests we have using this Hibernate 6 TimesTen community dialect.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

…LimitHandler and TimesTenSequenceSupport

…ate contributor. Also addressing some comments from the PR

hibernate-github-bot · 2025-07-08T21:48:48Z

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
↳ Offending commits: [c0d86b2, cfe66c4, 470845b, a41b2da, f20e73e, 7a81939]

› This message was automatically generated.

carlblan · 2025-07-08T22:14:09Z

@beikov @mbellade @yrodiere

Here's a new PR to update the TimesTen Community Dialect for Hibernate 6.6

I closed the previous PR: #10273
Since I accidentally fetched/updated from main instead of 6.6 branch

This is a clean PR with the same changes but addressed the previous comments:

Removed the copyright headers from my changes since Oracle has been added as a corporate contributor.
Addressed comments for 'initializeFunctionRegistry()'

Let me know any other comment.

Thanks

beikov · 2025-07-14T09:31:30Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+			case SqlTypes.BLOB:
+				return "BLOB";
+			case SqlTypes.CLOB:
+				return "CLOB";
+			case SqlTypes.NCLOB:
+				return "NCLOB";


If you look at the Dialect implementation, you will notice that the LOB handling here is redundant.

beikov · 2025-07-14T09:32:32Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

 			case SqlTypes.TINYINT:
-				return "tt_tinyint";
+				return "TT_TINYINT";


Please revert the all type names in this function to lower case again.

beikov · 2025-07-14T12:17:47Z

...mmunity-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

+			}
+		}
+		else if ( offsetClauseExpression != null && fetchClauseExpression == null ) {
+			throw new UnsupportedOperationException( 


Can't you use e.g. Integer.MAX_VALUE then?

beikov · 2025-07-14T12:18:42Z

...mmunity-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

+			try {
+				// TimesTen includes both m and n rows of 'ROWS m to n'; 
+				// We need to substract 1 row to fit maxRows
+				renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );


Does TimesTen not support a parameter here?

Suggested change

renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );

renderFetchPlusOffsetExpressionAsSingleParameter( fetchClauseExpression, offsetClauseExpression, -1 );

beikov · 2025-07-14T12:19:33Z

...mmunity-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

@@ -143,4 +145,56 @@ protected boolean supportsRowValueConstructorSyntaxInInList() {
 	protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
 		return false;
 	}
+
+	@Override


Since this function is only used in TimesTen, could you please remove it from AbstractSqlAstTranslator?

beikov · 2025-07-14T12:23:07Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+			case SqlTypes.TIMESTAMP:
+				return "TIMESTAMP";


No need to do this, as the Dialect implementation already handles timestamp.

Suggested change

case SqlTypes.TIMESTAMP:

return "TIMESTAMP";

beikov · 2025-07-14T12:25:10Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+			case SqlTypes.CHAR:
+				return "CHAR($l)";
+			case SqlTypes.VARCHAR:
+			case SqlTypes.LONGVARCHAR:
+				return "VARCHAR2($l)";
+
+			case SqlTypes.BINARY:
+				return "BINARY($l)";
+			case SqlTypes.VARBINARY:
+			case SqlTypes.LONGVARBINARY:
+				return "VARBINARY($l)";
+


Only need to handle the varchar type.

Suggested change

case SqlTypes.CHAR:

return "CHAR($l)";

case SqlTypes.VARCHAR:

case SqlTypes.LONGVARCHAR:

return "VARCHAR2($l)";

case SqlTypes.BINARY:

return "BINARY($l)";

case SqlTypes.VARBINARY:

case SqlTypes.LONGVARBINARY:

return "VARBINARY($l)";

case SqlTypes.LONGVARCHAR:

return "varchar2($l)";

carlblan added 6 commits July 8, 2025 19:58

Adding updates to TimesTenDialect, TimesTenSqlAstTranslator, TimesTen…

c0d86b2

…LimitHandler and TimesTenSequenceSupport

Fix indentation

cfe66c4

Fix typo

470845b

Changes in copyright headers

a41b2da

Fix indentation

f20e73e

Removing Copyright headers now that Oracle has been added as a corpor…

7a81939

…ate contributor. Also addressing some comments from the PR

carlblan changed the title ~~Oracle TimesTen 6.6 Dialect Updates~~ Oracle TimesTen Dialect for Hibernate 6.6 Updates Jul 8, 2025

beikov requested changes Jul 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

Uh oh!

carlblan commented Jul 8, 2025

Uh oh!

hibernate-github-bot bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

carlblan commented Jul 8, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

beikov Jul 14, 2025

Uh oh!

Uh oh!

	renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );
	renderFetchPlusOffsetExpressionAsSingleParameter( fetchClauseExpression, offsetClauseExpression, -1 );

Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

Are you sure you want to change the base?

Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

Uh oh!

Conversation

carlblan commented Jul 8, 2025

Uh oh!

hibernate-github-bot bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlblan commented Jul 8, 2025

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

beikov Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hibernate-github-bot bot commented Jul 8, 2025 •

edited

Loading