HHH-19704 listagg on overflow #10759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
requested changes
Aug 15, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/test/java/org/hibernate/orm/test/sql/TemplateTest.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Aug 15, 2025
hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java
Outdated
Show resolved
Hide resolved
michaelfranz
force-pushed
the
HHH-19704-listagg-on-overflow
branch
from
5d6e123 to
aa6fb4d
Compare
added 3 commits
August 17, 2025 10:58
…nto HHH-19704-listagg-on-overflow # Conflicts: # hibernate-core/src/test/java/org/hibernate/orm/test/sql/TemplateTest.java
|
Can't help noticing this PR's associated ticket has been stuck on Waiting for review for some time: https://hibernate.atlassian.net/browse/HHH-19704 The fix has been implemented in the same spirit as some very recently performed changes. It has undergone extensive testing. I know projects, which desperately need it. Fingers crossed we can see some movement soon. |
added 5 commits
August 20, 2025 13:52
…nto HHH-19704-listagg-on-overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue addressed in HHH-19704 with enhancements to Template.java plus its corresponding TemplateTest.
@gavinking 's last enhancement of this class addressed a problem with FETCH FIRST/PREV. HHH-19704 is essentially the same technical problem applied to another subset of tokens, which may be keywords depending on context.
The Template class's increased complexity is an unfortunate side-effect of this enhancement. The goal was to solve the problem, not create a total re-write of something that evidently works. I have enhanced TemplateTest above and beyond that HHH-19704 actually calls for. These enhancements ensure the vast majority of Template's many branches are touched by the test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19704